JackPosixProcessSync: Fix mutex owner on TimedWait() timeout. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per POSIX definition, pthread_cond_timedwait() re-acquires the mutex when a timeout occurs and ETIMEDOUT is returned. In that case also mark the waiting thread as owner again, for consistency. Otherwise subsequent attempts to unlock the mutex will fail, leaving the mutex locked forever.
|
Same here, should I just merge this if nobody's got time for a review? |
|
Would be nice to confirm with some automated testing that we do not get regressions, but since as you say this is only used for BSD the breakge is more minimal and I can assume you tested it. |
|
It's difficult to test for regression when the code isn't even in use ;-) I only discovered this problem when testing #943 - the timed wait treated a timeout like an error. Which left the mutex locked, but with ownership unset, and thus prevented any further unlocking of the mutex. I'm pretty sure that behavior was wrong and this patch at least improved it. Thread synchronization has been robust since then, so I'm gonna merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per POSIX definition, pthread_cond_timedwait() re-acquires the mutex when a timeout occurs and ETIMEDOUT is returned. In that case also mark the waiting thread as owner again, for consistency. Otherwise subsequent attempts to unlock the mutex will fail, leaving the mutex locked forever.
The return value of TimedWait() is still false on timeout, the same as for other platform's implementations.
But AFAICT, JackPosixProcessSync::TimedWait() is only used by my new FreeBSD OSS backend, see #943.